From commits-return-110568-archive-asf-public=cust-asf.ponee.io@mxnet.incubator.apache.org Tue Dec 31 01:54:27 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id E34B0180657 for ; Tue, 31 Dec 2019 02:54:26 +0100 (CET) Received: (qmail 75258 invoked by uid 500); 31 Dec 2019 01:54:26 -0000 Mailing-List: contact commits-help@mxnet.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@mxnet.incubator.apache.org Delivered-To: mailing list commits@mxnet.incubator.apache.org Received: (qmail 75248 invoked by uid 99); 31 Dec 2019 01:54:25 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 31 Dec 2019 01:54:25 +0000 From: GitBox To: commits@mxnet.apache.org Subject: [GitHub] [incubator-mxnet] ciyongch commented on a change in pull request #17187: [MKLDNN] Support channel wise quantization for FullyConnected Message-ID: <157775726579.6264.14261995747561672037.gitbox@gitbox.apache.org> References: In-Reply-To: Date: Tue, 31 Dec 2019 01:54:25 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit ciyongch commented on a change in pull request #17187: [MKLDNN] Support channel wise quantization for FullyConnected URL: https://github.com/apache/incubator-mxnet/pull/17187#discussion_r362134357 ########## File path: python/mxnet/contrib/quantization.py ########## @@ -978,7 +1004,7 @@ def __exit__(self, exc_type, exc_value, traceback): net.collect_params().reset_ctx(ctx) return net -def quantize_net(network, quantized_dtype='auto', quantize_mode='full', +def quantize_net(network, quantized_dtype='auto', quantize_mode='full', quantize_granularity='tensor-wise', Review comment: That make sense, so let's keep the `quantize_net` api as is, only adding the new params in `v2` version. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services