From commits-return-110418-archive-asf-public=cust-asf.ponee.io@mxnet.incubator.apache.org Mon Dec 30 02:31:41 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id 939D318063F for ; Mon, 30 Dec 2019 03:31:41 +0100 (CET) Received: (qmail 42559 invoked by uid 500); 30 Dec 2019 02:31:40 -0000 Mailing-List: contact commits-help@mxnet.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@mxnet.incubator.apache.org Delivered-To: mailing list commits@mxnet.incubator.apache.org Received: (qmail 42550 invoked by uid 99); 30 Dec 2019 02:31:40 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 30 Dec 2019 02:31:40 +0000 From: GitBox To: commits@mxnet.apache.org Subject: [GitHub] [incubator-mxnet] ciyongch commented on a change in pull request #17187: [MKLDNN] Support channel wise quantization for FullyConnected Message-ID: <157767310078.25209.16985678348725488969.gitbox@gitbox.apache.org> References: In-Reply-To: Date: Mon, 30 Dec 2019 02:31:40 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit ciyongch commented on a change in pull request #17187: [MKLDNN] Support channel wise quantization for FullyConnected URL: https://github.com/apache/incubator-mxnet/pull/17187#discussion_r361887846 ########## File path: python/mxnet/contrib/quantization.py ########## @@ -109,6 +110,9 @@ def _quantize_symbol(sym, ctx, excluded_symbols=None, excluded_operators=None, The quantized destination type for input data. quantize_mode: str The mode that quantization pass to apply. + quantize_granularity: str + The granularity of quantization, currently supports 'tensor-wise' and 'channel-wise' Review comment: I thought `tensor` and `channel` is not that descriptive for the argument. There's also `per-axis`/`per-channel` and `per-tensor` naming, which is similar to `channel-wise` and `tensor-wise`. Better to keep this? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services