From commits-return-110563-apmail-mxnet-commits-archive=mxnet.apache.org@mxnet.incubator.apache.org Tue Dec 31 00:54:20 2019 Return-Path: X-Original-To: apmail-mxnet-commits-archive@minotaur.apache.org Delivered-To: apmail-mxnet-commits-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by minotaur.apache.org (Postfix) with SMTP id 08EB219920 for ; Tue, 31 Dec 2019 00:54:19 +0000 (UTC) Received: (qmail 22458 invoked by uid 500); 31 Dec 2019 00:54:19 -0000 Delivered-To: apmail-mxnet-commits-archive@mxnet.apache.org Received: (qmail 22434 invoked by uid 500); 31 Dec 2019 00:54:19 -0000 Mailing-List: contact commits-help@mxnet.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@mxnet.incubator.apache.org Delivered-To: mailing list commits@mxnet.incubator.apache.org Received: (qmail 22425 invoked by uid 99); 31 Dec 2019 00:54:19 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 31 Dec 2019 00:54:19 +0000 From: GitBox To: commits@mxnet.apache.org Subject: [GitHub] [incubator-mxnet] ciyongch commented on a change in pull request #17187: [MKLDNN] Support channel wise quantization for FullyConnected Message-ID: <157775365925.27555.9063648266974892053.gitbox@gitbox.apache.org> References: In-Reply-To: Date: Tue, 31 Dec 2019 00:54:19 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit ciyongch commented on a change in pull request #17187: [MKLDNN] Support channel wise quantization for FullyConnected URL: https://github.com/apache/incubator-mxnet/pull/17187#discussion_r362129566 ########## File path: tests/python/mkl/test_subgraph.py ########## @@ -767,7 +773,7 @@ def test_pos_conv_bn_sum_act(): "softrelu": True, "relu6": False, "leakyrelu": True, - "gelu": True} + "gelu": False} Review comment: Convolution with post sum and activation only supports "relu" currently, previously UT didn't catch such failure. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services