From commits-return-110556-apmail-mxnet-commits-archive=mxnet.apache.org@mxnet.incubator.apache.org Tue Dec 31 00:31:08 2019 Return-Path: X-Original-To: apmail-mxnet-commits-archive@minotaur.apache.org Delivered-To: apmail-mxnet-commits-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by minotaur.apache.org (Postfix) with SMTP id D99CE19896 for ; Tue, 31 Dec 2019 00:31:07 +0000 (UTC) Received: (qmail 12765 invoked by uid 500); 31 Dec 2019 00:31:07 -0000 Delivered-To: apmail-mxnet-commits-archive@mxnet.apache.org Received: (qmail 12729 invoked by uid 500); 31 Dec 2019 00:31:07 -0000 Mailing-List: contact commits-help@mxnet.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@mxnet.incubator.apache.org Delivered-To: mailing list commits@mxnet.incubator.apache.org Received: (qmail 12720 invoked by uid 99); 31 Dec 2019 00:31:07 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 31 Dec 2019 00:31:07 +0000 From: GitBox To: commits@mxnet.apache.org Subject: [GitHub] [incubator-mxnet] ciyongch commented on a change in pull request #17187: [MKLDNN] Support channel wise quantization for FullyConnected Message-ID: <157775226713.22728.12859409836169256129.gitbox@gitbox.apache.org> References: In-Reply-To: Date: Tue, 31 Dec 2019 00:31:07 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit ciyongch commented on a change in pull request #17187: [MKLDNN] Support channel wise quantization for FullyConnected URL: https://github.com/apache/incubator-mxnet/pull/17187#discussion_r362127374 ########## File path: src/operator/quantization/quantized_batch_norm.cc ########## @@ -135,11 +135,9 @@ NNVM_REGISTER_OP(BatchNorm) } return node; }) -.set_attr("FAvoidQuantizeInput", [](const NodeAttrs &attrs, size_t index) { - if (index == 0) - return false; - else - return true; +.set_attr("FAvoidQuantizeInput", []( + const NodeAttrs &attrs, const size_t index, const std::string quantize_granularity) { + return (index == 0) ? false : true; Review comment: No, the attribute of this op is different than others. Check [here](https://github.com/apache/incubator-mxnet/blob/master/src/operator/quantization/quantized_batch_norm.cc#L139). ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services