mxnet-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [incubator-mxnet] TaoLv commented on a change in pull request #17187: [MKLDNN] Support channel wise quantization for FullyConnected
Date Tue, 31 Dec 2019 01:50:36 GMT
TaoLv commented on a change in pull request #17187: [MKLDNN] Support channel wise quantization
for FullyConnected
URL: https://github.com/apache/incubator-mxnet/pull/17187#discussion_r362134075
 
 

 ##########
 File path: python/mxnet/contrib/quantization.py
 ##########
 @@ -978,7 +1004,7 @@ def __exit__(self, exc_type, exc_value, traceback):
         net.collect_params().reset_ctx(ctx)
     return net
 
-def quantize_net(network, quantized_dtype='auto', quantize_mode='full',
+def quantize_net(network, quantized_dtype='auto', quantize_mode='full', quantize_granularity='tensor-wise',
 
 Review comment:
   I don't know if there is a better way to handle this kind of change. Since `quantize_net`
is an user interface and has been released, adding new parameters to it might break user workloads.
One convention is to add `v2` implementation, deprecate the original one, and replace it in
the next major release. The `v2` implementation is not released yet, so I think it's safe
to change it to add `quantize_granularity`. If it's released, yes, we might need `v3` implementation.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message