mxnet-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [incubator-mxnet] ciyongch commented on a change in pull request #17187: [MKLDNN] Support channel wise quantization for FullyConnected
Date Tue, 31 Dec 2019 00:54:19 GMT
ciyongch commented on a change in pull request #17187: [MKLDNN] Support channel wise quantization
for FullyConnected
URL: https://github.com/apache/incubator-mxnet/pull/17187#discussion_r362129566
 
 

 ##########
 File path: tests/python/mkl/test_subgraph.py
 ##########
 @@ -767,7 +773,7 @@ def test_pos_conv_bn_sum_act():
               "softrelu": True,
               "relu6": False,
               "leakyrelu": True,
-              "gelu": True}
+              "gelu": False}
 
 Review comment:
   Convolution with post sum and activation only supports "relu" currently, previously UT
didn't catch such failure.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message