mxnet-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [incubator-mxnet] ciyongch commented on a change in pull request #17187: [MKLDNN] Support channel wise quantization for FullyConnected
Date Tue, 31 Dec 2019 00:42:05 GMT
ciyongch commented on a change in pull request #17187: [MKLDNN] Support channel wise quantization
for FullyConnected
URL: https://github.com/apache/incubator-mxnet/pull/17187#discussion_r362128486
 
 

 ##########
 File path: python/mxnet/contrib/quantization.py
 ##########
 @@ -978,7 +1004,7 @@ def __exit__(self, exc_type, exc_value, traceback):
         net.collect_params().reset_ctx(ctx)
     return net
 
-def quantize_net(network, quantized_dtype='auto', quantize_mode='full',
+def quantize_net(network, quantized_dtype='auto', quantize_mode='full', quantize_granularity='tensor-wise',
 
 Review comment:
   Looks like the only difference between `quantize_net_v2` and `quantize_net` is the new
param `LayerOutputCollector` so far, `quantize_granularity` will be another new param introduced
by this PR.
   As there's not any other difference, how about jsut combine these two API into one?
   Otherwise, there could be `v3`, `v4` version in the future if there's new param needed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message