mxnet-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [incubator-mxnet] ciyongch commented on a change in pull request #17187: [MKLDNN] Support channel wise quantization for FullyConnected
Date Tue, 31 Dec 2019 00:30:43 GMT
ciyongch commented on a change in pull request #17187: [MKLDNN] Support channel wise quantization
for FullyConnected
URL: https://github.com/apache/incubator-mxnet/pull/17187#discussion_r362127374
 
 

 ##########
 File path: src/operator/quantization/quantized_batch_norm.cc
 ##########
 @@ -135,11 +135,9 @@ NNVM_REGISTER_OP(BatchNorm)
     }
     return node;
   })
-.set_attr<FAvoidQuantizeInput>("FAvoidQuantizeInput", [](const NodeAttrs &attrs,
size_t index) {
-  if (index == 0)
-    return false;
-  else
-    return true;
+.set_attr<FAvoidQuantizeInput>("FAvoidQuantizeInput", [](
+  const NodeAttrs &attrs, const size_t index, const std::string quantize_granularity)
{
+  return (index == 0) ? false : true;
 
 Review comment:
   No, the attribute of this op is different than others. Check [here](https://github.com/apache/incubator-mxnet/blob/master/src/operator/quantization/quantized_batch_norm.cc#L139).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message