mxnet-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [incubator-mxnet] ciyongch commented on a change in pull request #17187: [MKLDNN] Support channel wise quantization for FullyConnected
Date Mon, 30 Dec 2019 06:33:36 GMT
ciyongch commented on a change in pull request #17187: [MKLDNN] Support channel wise quantization
for FullyConnected
URL: https://github.com/apache/incubator-mxnet/pull/17187#discussion_r361907836
 
 

 ##########
 File path: include/mxnet/c_api.h
 ##########
 @@ -1944,8 +1945,8 @@ MXNET_DLL int MXQuantizeSymbol(SymbolHandle sym_handle,
                                const char **excluded_op_names,
                                const uint32_t num_offline, const char **offline_params,
                                const char *quantized_dtype, const bool calib_quantize,
-                               const char *quantize_mode, uint32_t* out_num_calib_names,
-                               const char ***out_calib_names);
+                               const char *quantize_mode, const char *quantize_granularity,
+                               uint32_t* out_num_calib_names, const char ***out_calib_names);
 
 Review comment:
   This API was called by `_quantize_symbol()` only, and  the new argument `quantize_granularity`
carries the default vale of `tensor-wise` from Python to C++ perspective. 
   For users doing quantization with `quantization.py`, setting `quantize_granularity` to
`channel-wise` explicitly to do channel-wise quantization for FullyConnected, otherwise it
will do tensor-wise quantization which is same as before (the default behavior).

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message