mxnet-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [incubator-mxnet] marcoabreu commented on a change in pull request #17063: Fix armv7 build by updating the base container and pin it
Date Mon, 16 Dec 2019 15:47:23 GMT
marcoabreu commented on a change in pull request #17063: Fix armv7 build by updating the base
container and pin it
URL: https://github.com/apache/incubator-mxnet/pull/17063#discussion_r358307698
 
 

 ##########
 File path: ci/docker/Dockerfile.build.armv7
 ##########
 @@ -18,7 +18,10 @@
 #
 # Dockerfile to build MXNet for Android ARMv7
 
-FROM mxnetcipinned/dockcross-linux-armv7:11262018
+# The container is pinned for preventing CI failures on updates, swap below to use 
+# the upstream container
+#FROM dockcross/linux-armv7
+FROM mxnetci/dockcross-linux-armv7-pinned
 
 Review comment:
   Mxnetci is a fully automatically handled repository while MXNetcipinned is manually curated.
In case there's a security breach, the pinned repo wouldn't be impacted. Since the pinned
image usually is no longer available at dockcross since they don't have tagging, the image
would then be lost if the image gets deleted by the automatic process. Thus, I'd recommend
to stay on the separate pinned repo

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message