mxnet-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [incubator-mxnet] xinyu-intel commented on a change in pull request #16931: [MKL-DNN] Enable and Optimization for s8 eltwise_add
Date Mon, 02 Dec 2019 03:12:23 GMT
xinyu-intel commented on a change in pull request #16931: [MKL-DNN] Enable and Optimization
for s8 eltwise_add
URL: https://github.com/apache/incubator-mxnet/pull/16931#discussion_r352405545
 
 

 ##########
 File path: src/operator/quantization/quantized_elemwise_add.cc
 ##########
 @@ -127,7 +127,6 @@ and max thresholds representing the threholds for quantizing the float32
output
 
 // TODO(zhangrong): need extra condition check if there's benefited if it's switched on
 // Since it's not compute-intensive.
-#if 0
 
 Review comment:
   I'll remove this `todo` since this operator is registered as `kSupport` quantize mode.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message