reminisce commented on a change in pull request #16913: [numpy] add op linalg solve URL: https://github.com/apache/incubator-mxnet/pull/16913#discussion_r351991412 ########## File path: python/mxnet/ndarray/numpy/linalg.py ########## @@ -352,3 +352,58 @@ def slogdet(a): (1., -1151.2925464970228) """ return _npi.slogdet(a) + + +def solve(a, b): + r""" + Solve a linear matrix equation, or system of linear scalar equations. + + Computes the "exact" solution, x, of the well-determined, i.e., full rank, linear matrix equation ax = b. + + Parameters : + a : (..., M, M) ndarray Review comment: Indent. And same for all the following doc. Please follow the same format as in https://github.com/numpy/numpy/blob/0725a58415e68eab9fa7d7389cdb40716447a4fb/numpy/linalg/linalg.py#L326-L381 ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services