mxnet-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [incubator-mxnet] ptrendx edited a comment on issue #16836: Fix InferAttr/InferShapeAttr not calling inference for all nodes in a graph
Date Mon, 18 Nov 2019 21:20:10 GMT
ptrendx edited a comment on issue #16836: Fix InferAttr/InferShapeAttr not calling inference
for all nodes in a graph
URL: https://github.com/apache/incubator-mxnet/pull/16836#issuecomment-555202627
 
 
   @junrushao1994 The failure in `test_contrib_control_flow.test_while_loop_simple_forward`
test in this PR is a legitimate bug in `WhileLoopType` function (https://github.com/apache/incubator-mxnet/blob/master/src/operator/control_flow.cc#L764),
where you always set the output type of condition to `float`. I do not really understand how
that function is supposed to work (e.g. you set the `cond_out_type` but then do not use it?),
could you take a look at it?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message