mxnet-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [incubator-mxnet] reminisce commented on a change in pull request #16829: [Numpy][Operator] 'where' Implementation in MXNet
Date Fri, 15 Nov 2019 22:33:50 GMT
reminisce commented on a change in pull request #16829: [Numpy][Operator] 'where' Implementation
in MXNet
URL: https://github.com/apache/incubator-mxnet/pull/16829#discussion_r347038122
 
 

 ##########
 File path: src/operator/numpy/np_where_op-inl.h
 ##########
 @@ -0,0 +1,266 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+/*!
+ * Copyright (c) 2017 by Contributors
+ * \file np_where_op.cc
+ * \brief Function definition of numpy operator where
+ */
+
+#ifndef MXNET_OPERATOR_NUMPY_NP_WHERE_OP_INL_H_
+#define MXNET_OPERATOR_NUMPY_NP_WHERE_OP_INL_H_
+
+#include <mxnet/operator_util.h>
+#include <algorithm>
+#include <string>
+#include <utility>
+#include <vector>
+#include "../../common/utils.h"
+#include "../mxnet_op.h"
+#include "../mshadow_op.h"
+#include "../operator_common.h"
+#include "np_broadcast_reduce_op.h"
+
+namespace mxnet {
+namespace op {
+
+#define NUMPY_WHERE_MAX_DIM 5
 
 Review comment:
   Change the name to `np_where_max_ndim`.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message