mxnet-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [incubator-mxnet] reminisce commented on a change in pull request #16827: Refactor NumPy-compatible elemwise broadcast operators
Date Fri, 15 Nov 2019 21:13:53 GMT
reminisce commented on a change in pull request #16827: Refactor NumPy-compatible elemwise
broadcast operators
URL: https://github.com/apache/incubator-mxnet/pull/16827#discussion_r347013187
 
 

 ##########
 File path: src/operator/tensor/elemwise_binary_op.h
 ##########
 @@ -474,6 +474,31 @@ class ElemwiseBinaryOp : public OpBase {
                                        std::vector<int> *in_attrs,
                                        std::vector<int> *out_attrs);
 
+  template<typename xpu, typename OP>
+  static void ComputeInt(const nnvm::NodeAttrs &attrs,
+                         const OpContext &ctx,
+                         const std::vector<TBlob> &inputs,
+                         const std::vector<OpReqType> &req,
+                         const std::vector<TBlob> &outputs) {
+    using namespace mxnet_op;
+    if (req[0] != kNullOp) {
 
 Review comment:
   To save then indentation for the following lines, you can return here if `req[0]` is `kNullOp`.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message