mxnet-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [incubator-mxnet] haojin2 commented on a change in pull request #16699: [DO NOT MERGE] [DO NOT REVIEW] [WIP]Mixed binary ops
Date Sun, 03 Nov 2019 10:35:35 GMT
haojin2 commented on a change in pull request #16699: [DO NOT MERGE] [DO NOT REVIEW] [WIP]Mixed
binary ops
URL: https://github.com/apache/incubator-mxnet/pull/16699#discussion_r341845058
 
 

 ##########
 File path: src/common/utils.h
 ##########
 @@ -870,12 +870,12 @@ inline int more_precise_type(const int type1, const int type2) {
   return mshadow::kInt8;
 }
 
-inline int np_binary_out_type(const int type1, const int type2) {
+inline int np_binary_out_infer_type(const int type1, const int type2) {
   if ((type1 == mshadow::kUint8 && type2 == mshadow::kInt8) ||
       (type1 == mshadow::kInt8 && type2 == mshadow::kUint8)) {
     return mshadow::kInt32;
   }
-  return more_precise_type(type1, type2);
+  return get_the_more_precise_type(type1, type2);
 
 Review comment:
   @reminisce 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message