mxnet-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [incubator-mxnet] zoeygxy commented on issue #13143: [MXNET-1206] Support NDArray indexing with None and Ellipsis
Date Mon, 19 Aug 2019 08:55:50 GMT
zoeygxy commented on issue #13143: [MXNET-1206] Support NDArray indexing with None and Ellipsis
URL: https://github.com/apache/incubator-mxnet/pull/13143#issuecomment-522477433
 
 
   > A `git show` of this PR's commit includes:
   > 
   > ```
   > diff --git a/python/mxnet/test_utils.py b/python/mxnet/test_utils.py
   > index 2275f4d5d..89013f439 100644
   > --- a/python/mxnet/test_utils.py
   > +++ b/python/mxnet/test_utils.py
   > @@ -1074,7 +1074,11 @@ def check_symbolic_forward(sym, location, expected, rtol=1E-4,
atol=None,
   >  
   >      executor = sym.bind(ctx=ctx, args=location, args_grad=args_grad_data, aux_states=aux_states)
   >      for g in executor.grad_arrays:
   > -        g[:] = 0
   > +        print(g.shape)
   > +        if g.ndim == 0:
   > +            g[()] = 0
   > +        else:
   > +            g[:] = 0
   >  
   > ```
   > 
   > Please confirm that the line `print(g.shape)` was a bit of debugging code inadvertently
left in, and so should be removed.
   
   @DickJC123 I believe so. Thanks for pointing out! I will take care of it. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message