mxnet-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [incubator-mxnet] marcoabreu commented on issue #15812: cuDNN support cleanup
Date Fri, 09 Aug 2019 05:15:43 GMT
marcoabreu commented on issue #15812: cuDNN support cleanup
URL: https://github.com/apache/incubator-mxnet/pull/15812#issuecomment-519781193
 
 
   Great to see this cleanup!
   
   While I understand the intention of the assert, I feel it's a bit obsolete and makes the
code a bit "cluttered" if you understand what I mean. Couldn't we have the assertion in a
central place (aka on-init) instead of re-asserting the same thing over and over? The minimum
CuDNN version is 7 and thus we treat it as default. That might make the code a bit more cleaner.
But I don't have strong feelings about that tbh.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message