mxnet-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [incubator-mxnet] ChaiBapchya opened a new pull request #15736: [OpPerf] Take care of 4d param
Date Fri, 02 Aug 2019 17:19:51 GMT
ChaiBapchya opened a new pull request #15736: [OpPerf] Take care of 4d param 
URL: https://github.com/apache/incubator-mxnet/pull/15736
 
 
   ## Description ##
   Previous PR #15606 introduced a bug (if condition resulted in ALWAYS using 4D tensor instead
of just using it specific to 2 ops)
   
   ## Checklist ##
   ### Essentials ###
   Please feel free to remove inapplicable items for your PR.
   - [ ] Changes are complete (i.e. I finished coding on this PR)
   - [ ] Code is well-documented: 
   - [ ] To the my best knowledge, examples are either not affected by this change, or have
been fixed to be compatible with this change
   
   ### Changes ###
   
   ## Comments ##
   Missed this because when I run benchmark tests they run without failure. 
   Just that input is 4d instead of default 2d tensors (of larger size)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message