From commits-return-91191-archive-asf-public=cust-asf.ponee.io@mxnet.incubator.apache.org Mon Jul 1 07:08:59 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id C292E180670 for ; Mon, 1 Jul 2019 09:08:58 +0200 (CEST) Received: (qmail 18367 invoked by uid 500); 1 Jul 2019 07:08:55 -0000 Mailing-List: contact commits-help@mxnet.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@mxnet.incubator.apache.org Delivered-To: mailing list commits@mxnet.incubator.apache.org Received: (qmail 18358 invoked by uid 99); 1 Jul 2019 07:08:55 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 01 Jul 2019 07:08:55 +0000 From: GitBox To: commits@mxnet.apache.org Subject: [GitHub] [incubator-mxnet] reminisce commented on issue #13143: [MXNET-1206] Support NDArray indexing with None and Ellipsis Message-ID: <156196493002.32760.15587666462993182278.gitbox@gitbox.apache.org> Date: Mon, 01 Jul 2019 07:08:50 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit reminisce commented on issue #13143: [MXNET-1206] Support NDArray indexing with None and Ellipsis URL: https://github.com/apache/incubator-mxnet/pull/13143#issuecomment-507143669 Thanks for addressing the cr comments. Since the logic of integer indexing and first-axis contiguous slicing have been organized into a more general case handling flow, could you verify there is no performance regression in the situation where an output ndarray sharing the memory with the input ndarray? This kind of indexing is used a lot in Gluon dataset loaders and is critical to the training performance. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services