From commits-return-88011-archive-asf-public=cust-asf.ponee.io@mxnet.incubator.apache.org Fri Jun 7 07:01:04 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id 6842818067E for ; Fri, 7 Jun 2019 09:01:04 +0200 (CEST) Received: (qmail 62416 invoked by uid 500); 7 Jun 2019 07:01:03 -0000 Mailing-List: contact commits-help@mxnet.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@mxnet.incubator.apache.org Delivered-To: mailing list commits@mxnet.incubator.apache.org Received: (qmail 62407 invoked by uid 99); 7 Jun 2019 07:01:03 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 07 Jun 2019 07:01:03 +0000 From: GitBox To: commits@mxnet.apache.org Subject: [GitHub] [incubator-mxnet] anandj91 commented on a change in pull request #15124: [MXNET-1294] Priority-based parameter propagation for improved data parallel training throughput Message-ID: <155989086337.16639.12730234904846225845.gitbox@gitbox.apache.org> Date: Fri, 07 Jun 2019 07:01:03 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit anandj91 commented on a change in pull request #15124: [MXNET-1294] Priority-based parameter propagation for improved data parallel training throughput URL: https://github.com/apache/incubator-mxnet/pull/15124#discussion_r291472650 ########## File path: src/kvstore/kvstore_dist.h ########## @@ -544,31 +592,25 @@ class KVStoreDist : public KVStoreLocal { const int num_servers = krs.size(); CHECK_GT(num_servers, 0); - // a simple heuristic for load balance - if (num_arr_elems < bigarray_bound_) { - // send it to a single random picked server - int server = (key * 9973) % num_servers; - ps::Key ps_key = krs[server].begin() + key; - CHECK_LT(ps_key, krs[server].end()); + /** + * Round-Robin key assignment + */ + int64_t params = pskv_size; + int64_t slice_bound = bigarray_bound_ * num_bytes; + static ps::Key server = 0; Review comment: the server variable is static. so it is incremented on every invocation of EncodeDefaultKey function. this does not cause overloading server 0. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services