From commits-return-87432-archive-asf-public=cust-asf.ponee.io@mxnet.incubator.apache.org Sat Jun 1 21:18:12 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id 9E60E18061A for ; Sat, 1 Jun 2019 23:18:11 +0200 (CEST) Received: (qmail 94586 invoked by uid 500); 1 Jun 2019 21:18:11 -0000 Mailing-List: contact commits-help@mxnet.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@mxnet.incubator.apache.org Delivered-To: mailing list commits@mxnet.incubator.apache.org Received: (qmail 94577 invoked by uid 99); 1 Jun 2019 21:18:11 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 01 Jun 2019 21:18:11 +0000 From: GitBox To: commits@mxnet.apache.org Subject: [GitHub] [incubator-mxnet] szha commented on a change in pull request #15106: NER example: fix metrics computation Message-ID: <155942389097.5770.5481149402071573000.gitbox@gitbox.apache.org> Date: Sat, 01 Jun 2019 21:18:10 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit szha commented on a change in pull request #15106: NER example: fix metrics computation URL: https://github.com/apache/incubator-mxnet/pull/15106#discussion_r289618624 ########## File path: example/named_entity_recognition/src/ner.py ########## @@ -135,12 +137,14 @@ def build_iters(data_dir, max_records, train_fraction, batch_size, buckets=None) # Split into training and testing data idx=int(len(indexed_tokens)*train_fraction) + logging.getLogger().info("Preparing train/test datasets splitting at idx %d on total %d sentences using a batchsize of %d" % (idx, len(indexed_tokens), batch_size)) Review comment: ```suggestion logging.info("Preparing train/test datasets splitting at idx %d on total %d sentences using a batchsize of %d", idx, len(indexed_tokens), batch_size) ``` ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services