mxnet-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [incubator-mxnet] Chouffe opened a new pull request #15121: [clojure] clojurify function names in image.clj namespace
Date Sat, 01 Jun 2019 18:56:26 GMT
Chouffe opened a new pull request #15121: [clojure] clojurify function names in image.clj namespace
URL: https://github.com/apache/incubator-mxnet/pull/15121
 
 
   ## Description ##
   
   The `image` namespace is using some functions that are not named the `clojure way`. It
is an attempt to clojurify these functions.
   The namespaces are supposed to be imported qualified and having the suffix `-image` in
the following functions is redundant
   * `resize-image`
   * `decode-image`
   * `read-image`
   
   One should be able to call `image/resize`, `image/decode`, `image/read` instead.
   
   The function `to-image` is misleading as we dont know what is turned into an image. I suggest
to name it `ndarray->image` instead.
   
   * `deprecated` is added in metadata
   * `deprecated` is added in docstrings

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message