mxnet-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [incubator-mxnet] wkcn opened a new pull request #14314: support long for mx.random.seed
Date Mon, 04 Mar 2019 06:52:58 GMT
wkcn opened a new pull request #14314: support long for mx.random.seed
URL: https://github.com/apache/incubator-mxnet/pull/14314
 
 
   ## Description ##
   Fix: https://github.com/apache/incubator-mxnet/issues/14233
   Support `int`, `long`, `np.int32` and `np.int64` as the argument of `mx.random.seed`
   
   
   ## Checklist ##
   ### Essentials ###
   Please feel free to remove inapplicable items for your PR.
   - [x] tiny change. The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to
the relevant [JIRA issue](https://issues.apache.org/jira/projects/MXNET/issues) created (except
PRs with tiny changes)
   - [x] Changes are complete (i.e. I finished coding on this PR)
   - [ ] All changes have test coverage:
   - Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
   - Nightly tests are added for complicated/long-running ones (e.g. changing distributed
kvstore)
   - Build tests will be added for build configuration changes (e.g. adding a new build option
with NCCL)
   - [x] Code is well-documented: 
   - For user-facing API changes, API doc string has been updated. 
   - For new C++ functions in header files, their functionalities and arguments are documented.

   - For new examples, README.md is added to explain the what the example does, the source
of the dataset, expected performance on test set and reference to the original paper if applicable
   - Check the API doc at http://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
   - [x] To the my best knowledge, examples are either not affected by this change, or have
been fixed to be compatible with this change
   
   ### Changes ###
   - [x] update mx.random.seed
   - [x] Add unittest
   
   ## Comments ##
   - If this change is a backward incompatible change, why must this change be made.
   - Interesting edge cases to note here
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message