From commits-return-67832-archive-asf-public=cust-asf.ponee.io@mxnet.incubator.apache.org Wed Dec 12 19:46:50 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 36D6318064E for ; Wed, 12 Dec 2018 19:46:50 +0100 (CET) Received: (qmail 74875 invoked by uid 500); 12 Dec 2018 18:46:49 -0000 Mailing-List: contact commits-help@mxnet.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@mxnet.incubator.apache.org Delivered-To: mailing list commits@mxnet.incubator.apache.org Received: (qmail 74866 invoked by uid 99); 12 Dec 2018 18:46:49 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 12 Dec 2018 18:46:49 +0000 From: GitBox To: commits@mxnet.apache.org Subject: [GitHub] Vikas89 commented on a change in pull request #13602: Fix for import mxnet taking long time if multiple process launched Message-ID: <154464040880.9628.4827656146983349010.gitbox@gitbox.apache.org> Date: Wed, 12 Dec 2018 18:46:48 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Vikas89 commented on a change in pull request #13602: Fix for import mxnet taking long time if multiple process launched URL: https://github.com/apache/incubator-mxnet/pull/13602#discussion_r241139065 ########## File path: src/operator/operator_tune-inl.h ########## @@ -56,7 +56,7 @@ namespace op { #endif #endif // MXNET_NO_INLINE -#define OUTSIDE_COUNT_SHIFT 9 Review comment: Workload_count_shift is currently 11, which means workload count will be 2048. this means that operation is done for 2048 times. This number can be made 10, but IsOMPFaster doesn't look like bottleneck for the related issue. It is the function which is calculating OMP overhead which is causing the problem. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services