mxnet-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] apeforest commented on issue #13362: Add NHWC layout support to Pooling (cuDNN only)
Date Thu, 06 Dec 2018 05:33:28 GMT
apeforest commented on issue #13362: Add NHWC layout support to Pooling (cuDNN only)
URL: https://github.com/apache/incubator-mxnet/pull/13362#issuecomment-444753750
 
 
   @DickJC123 Thanks for your detailed explanation about the operator selection logic. I like
the way you used a boolean return type for `Forward()` and `Backward()` methods to choose
the right operator implementation. Although it might be an elegant way, this method is not
yet well received in the developer community. And all the other operators do not currently
implement in this way. I am afraid that using it alone in this operator without a clear guideline
may cause more confusion for prospect developers. Can you still follow the traditional way
of declaring `Forward()` and `Backward()` function and maybe propose this in a separate thread
to refactor the `Forward()` and `Backward()` with boolean return type? 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message