mxnet-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] ptrendx commented on a change in pull request #13362: Add NHWC layout support to Pooling (cuDNN only)
Date Wed, 05 Dec 2018 23:26:38 GMT
ptrendx commented on a change in pull request #13362: Add NHWC layout support to Pooling (cuDNN
only)
URL: https://github.com/apache/incubator-mxnet/pull/13362#discussion_r239277593
 
 

 ##########
 File path: python/mxnet/gluon/nn/conv_layers.py
 ##########
 @@ -738,12 +741,13 @@ class MaxPool1D(_Pooling):
     """
     def __init__(self, pool_size=2, strides=None, padding=0, layout='NCW',
                  ceil_mode=False, **kwargs):
-        assert layout == 'NCW', "Only supports 'NCW' layout for now"
+        assert layout in ('NCW', 'NWC'),\
+            "Only NCW and NWC layouts are valid for 1D"
 
 Review comment:
   Will do.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message