mxnet-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] marcoabreu edited a comment on issue #12784: Improved git reset for CI builds
Date Tue, 16 Oct 2018 13:18:14 GMT
marcoabreu edited a comment on issue #12784: Improved git reset for CI builds
URL: https://github.com/apache/incubator-mxnet/pull/12784#issuecomment-430233561
 
 
   > This will save builds from CI failure that had modified checked in code for whatever
reason.
   Do you have an example of such a case?
   
   > What is the strategy and what are we validating with it? My PR ensures that for every
build attempt we have a guaranteed clean default state.
   
   The strategy merges your PR with the head of master. This allows us to always validate
a PR as if it would be merged at that moment opposed to requiring the user to rebase constantly.
This change would revert this merge and effectively switch from a "PR-merge" to a "PR-head"
strategy. 
   
   The problem with your PR is that it's actually purging too much and putting the repository
into a "too" clean state. It's effectively invalidating Jenkins' actions.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message