mxnet-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] apeforest commented on a change in pull request #12687: ignore a 3rd party libray in cpplint
Date Fri, 28 Sep 2018 21:56:29 GMT
apeforest commented on a change in pull request #12687: ignore a 3rd party libray in cpplint
URL: https://github.com/apache/incubator-mxnet/pull/12687#discussion_r221390585
 
 

 ##########
 File path: Makefile
 ##########
 @@ -568,7 +568,7 @@ lint: cpplint rcpplint jnilint pylint
 
 cpplint:
 	3rdparty/dmlc-core/scripts/lint.py mxnet cpp include src plugin cpp-package tests \
-	--exclude_path src/operator/contrib/ctc_include
+	--exclude_path src/operator/contrib/ctc_include src/operator/nn/ctc_include
 
 Review comment:
   Hi @szha, what's the guideline for moving an operator implementation and its 3rd party
dependency from contrib to MXNet native? Thanks! 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message