mxnet-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] aaronmarkham opened a new pull request #12388: Installation instructions consolidation
Date Wed, 29 Aug 2018 00:25:28 GMT
aaronmarkham opened a new pull request #12388: Installation instructions consolidation
URL: https://github.com/apache/incubator-mxnet/pull/12388
 
 
   ## Description ##
   Different installation pages were out of date or out of sync. The install page was over-complicated.
The build from source instructions weren't really working.
   
   This PR consolidates install info, directs users to where the more recent updates happen
to be, and simplifies the basic user install. I started off just trying to fix the C++ setup
info, but found so many other issues, I worked on those too.
   
   ## Features
   * Fixes a bug that made it so you couldn't preview the dev version's install page without
it redirecting you. (options.js)
   * Updates the [build_from_source](http://34.201.8.176/versions/cplusplus_install/install/build_from_source.html)
page 
       - Point to the OS-focused pages where this information is most up-to-date.
       - Added a [table that maps links to each binding](http://34.201.8.176/versions/cplusplus_install/install/build_from_source.html#installing-mxnet-language-bindings).
       - Leaves the centos/other linux sections there since this info isn't covered elsewhere
       - Leaves the NCCL section alone (is this even current info?)
       - Links this page in the [Download Source section](http://34.201.8.176/versions/cplusplus_install/install/index.html)
found at the bottom of install
   * Creates a new [C++ setup page](http://34.201.8.176/versions/cplusplus_install/install/c_plus_plus.html)
that brings together C++ info found around the project.
   * Refactors the install page. 
       - Moves the [validation section to a new page](http://34.201.8.176/versions/cplusplus_install/install/validate_mxnet.html)
       - Removes virtualenv (this was repeated multiple times in the file w/o much real value
       - Super simplifies the pip install sections
       - Links back to each OS's detailed setup guides
       - Links to specific install guide sections for Perl and Julia
       - and more... the file went from 2531 lines to 1062. So much easier to deal with...
probably could take more pruning...
   * Fixes some issues on the OS guide pages - the Python binding steps were missing
   
   ## Preview
   http://34.201.8.176/versions/cplusplus_install/install/index.html
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message