mxnet-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] andrewfayres commented on a change in pull request #12110: [MXNET-730][WIP] Scala test in nightly
Date Thu, 09 Aug 2018 22:07:39 GMT
andrewfayres commented on a change in pull request #12110: [MXNET-730][WIP] Scala test in nightly
URL: https://github.com/apache/incubator-mxnet/pull/12110#discussion_r209094090
 
 

 ##########
 File path: scala-package/examples/src/main/scala/org/apache/mxnetexamples/Util.scala
 ##########
 @@ -42,4 +48,30 @@ object Util {
     }
    if (!success) throw new Exception(s"$url Download failed!")
   }
+
+  /**
+    * This Util is designed to manage the tests in CI
+    * @param name the name of the test
+    * @return runTest and number of epoch
+    */
+  def testManager(name: String) : (Boolean, Int) = {
 
 Review comment:
   Agreeing with Naveen here. Convention is that we control this type of behavior through
something like environment variables, build parameters, or config files.
   
   One other thing is that we should try to avoid having code which is unique to our CI testing
inside the src folder.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message