From commits-return-46201-archive-asf-public=cust-asf.ponee.io@mxnet.incubator.apache.org Wed Jul 25 22:20:18 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id D0D6D18062C for ; Wed, 25 Jul 2018 22:20:17 +0200 (CEST) Received: (qmail 4793 invoked by uid 500); 25 Jul 2018 20:20:17 -0000 Mailing-List: contact commits-help@mxnet.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@mxnet.incubator.apache.org Delivered-To: mailing list commits@mxnet.incubator.apache.org Received: (qmail 4784 invoked by uid 99); 25 Jul 2018 20:20:16 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 25 Jul 2018 20:20:16 +0000 From: GitBox To: commits@mxnet.apache.org Subject: [GitHub] hcho3 commented on a change in pull request #11873: [MXNET-582] Fix flaky test test_operator_gpu.test_batchnorm_with_type (follow-up) Message-ID: <153255001642.7976.8392200583423229078.gitbox@gitbox.apache.org> Date: Wed, 25 Jul 2018 20:20:16 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit hcho3 commented on a change in pull request #11873: [MXNET-582] Fix flaky test test_operator_gpu.test_batchnorm_with_type (follow-up) URL: https://github.com/apache/incubator-mxnet/pull/11873#discussion_r205248885 ########## File path: tests/python/gpu/test_operator_gpu.py ########## @@ -290,12 +289,12 @@ def test_batchnorm_with_type(): ] ctx_list_v2_3D = [ - {'ctx': mx.cpu(0), 'norm_data': (4, 2, 3, 5, 5), 'type_dict': {'norm_data': np.float16}}, - {'ctx': mx.cpu(0), 'norm_data': (4, 2, 3, 5, 5), 'type_dict': {'norm_data': np.float32}}, - {'ctx': mx.cpu(0), 'norm_data': (4, 2, 3, 5, 5), 'type_dict': {'norm_data': np.float64}}, - {'ctx': mx.gpu(0), 'norm_data': (4, 2, 3, 5, 5), 'type_dict': {'norm_data': np.float16}}, - {'ctx': mx.gpu(0), 'norm_data': (4, 2, 3, 5, 5), 'type_dict': {'norm_data': np.float32}}, - {'ctx': mx.gpu(0), 'norm_data': (4, 2, 3, 5, 5), 'type_dict': {'norm_data': np.float64}} + {'ctx': mx.cpu(0), 'norm_data': (3, 2, 3, 2, 3), 'type_dict': {'norm_data': np.float16}}, + {'ctx': mx.cpu(0), 'norm_data': (3, 2, 3, 2, 3), 'type_dict': {'norm_data': np.float32}}, + {'ctx': mx.cpu(0), 'norm_data': (3, 2, 3, 2, 3), 'type_dict': {'norm_data': np.float64}}, + {'ctx': mx.gpu(0), 'norm_data': (3, 2, 3, 2, 3), 'type_dict': {'norm_data': np.float16}}, + {'ctx': mx.gpu(0), 'norm_data': (3, 2, 3, 2, 3), 'type_dict': {'norm_data': np.float32}}, + {'ctx': mx.gpu(0), 'norm_data': (3, 2, 3, 2, 3), 'type_dict': {'norm_data': np.float64}} Review comment: Also, notice that #11396 did not modify `ctx_list_v2_3D`. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services