mxnet-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] marcoabreu commented on a change in pull request #11630: [WIP] Fix flaky test test_deconvolution
Date Wed, 11 Jul 2018 21:00:15 GMT
marcoabreu commented on a change in pull request #11630: [WIP] Fix flaky test test_deconvolution
URL: https://github.com/apache/incubator-mxnet/pull/11630#discussion_r201837431
 
 

 ##########
 File path: tests/python/unittest/common.py
 ##########
 @@ -94,6 +95,23 @@ def random_seed(seed=None):
         random.seed(next_seed)
 
 
+def assert_raises_cudnn_disabled(assertion_error=False):
+    def test_helper(orig_test):
+        @make_decorator(orig_test)
+        def test_new(*args, **kwargs):
+            cudnn_disabled = (os.getenv('CUDNN_DISABLED') == "ON")
+            if not cudnn_disabled or mx.context.current_context().device_type == 'cpu':
+                orig_test(*args, **kwargs)
+            else:
+                if assertion_error:
 
 Review comment:
   Sure, as you prefer. Just wanted to avoid having this hack in there, but I don't mind.
Could you please add a comment in that test, linking to the issue and stating that the test
is disabled when running without cudnn?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message