mxnet-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] haojin2 opened a new pull request #11631: Fix batchnorm problem with sparse matrices when fix_gamma=True
Date Tue, 10 Jul 2018 18:15:41 GMT
haojin2 opened a new pull request #11631: Fix batchnorm problem with sparse matrices when fix_gamma=True
URL: https://github.com/apache/incubator-mxnet/pull/11631
 
 
   ## Description ##
   As title.
   
   ## Checklist ##
   ### Essentials ###
   - [x] Changes are complete (i.e. I finished coding on this PR)
   - [x] All changes have test coverage:
   - Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
   - Nightly tests are added for complicated/long-running ones (e.g. changing distributed
kvstore)
   - Build tests will be added for build configuration changes (e.g. adding a new build option
with NCCL)
   - [x] Code is well-documented: 
   - For user-facing API changes, API doc string has been updated. 
   - For new C++ functions in header files, their functionalities and arguments are documented.

   - For new examples, README.md is added to explain the what the example does, the source
of the dataset, expected performance on test set and reference to the original paper if applicable
   - Check the API doc at http://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
   - [x] To the my best knowledge, examples are either not affected by this change, or have
been fixed to be compatible with this change
   
   ### Changes ###
   - [x] Fix fallback logic for batchnorm operator
   - [x] Block usage of fix_gamma=True when input is sparse
   - [x] Unit tests
   
   ## Comments ##
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message