mxnet-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] asitstands commented on issue #11134: [MXNET-507] Set dtype=int32 for ret_indices in ordering ops
Date Mon, 11 Jun 2018 13:30:30 GMT
asitstands commented on issue #11134: [MXNET-507] Set dtype=int32 for ret_indices in ordering
ops
URL: https://github.com/apache/incubator-mxnet/pull/11134#issuecomment-396243589
 
 
   I think that it would be helpful if a check for the ranges of the floating point types
is added. The recent addtion of `dtype` to `multinomial` implemented the check. https://github.com/apache/incubator-mxnet/blob/3eada3b32aeab5c8cdf7d507bcc3a986c9e5b91f/src/operator/random/sample_multinomial_op.h#L73-L76

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message