mxnet-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] anirudhacharya commented on a change in pull request #10605: [MXNET-310] [ONNX-MXNet] API to import ONNX models into Gluon.
Date Thu, 31 May 2018 19:32:35 GMT
anirudhacharya commented on a change in pull request #10605: [MXNET-310] [ONNX-MXNet] API to
import ONNX models into Gluon.
URL: https://github.com/apache/incubator-mxnet/pull/10605#discussion_r192212208
 
 

 ##########
 File path: python/mxnet/contrib/onnx/_import/translation_utils.py
 ##########
 @@ -148,21 +152,29 @@ def _fix_bias(op_name, attrs, num_inputs):
         raise ValueError("Unexpected number of inputs for: {}".format(op_name))
     return attrs
 
-def _fix_bias_shape(op_name, inputs, cls):
+def _fix_broadcast(op_name, inputs, broadcast_axis, cls):
 
 Review comment:
   no I meant to use ``cls``, its just a convention, but the same way ``self`` is used to
access an attribute inside the object (class) itself.``cls`` is often used to reference class
and instance variables outside the object.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message