mxnet-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] spidyDev commented on a change in pull request #10726: Fix for cpp examples in mxnet/cpp-package.
Date Mon, 07 May 2018 17:40:26 GMT
spidyDev commented on a change in pull request #10726: Fix for cpp examples in mxnet/cpp-package.
URL: https://github.com/apache/incubator-mxnet/pull/10726#discussion_r186493868
 
 

 ##########
 File path: cpp-package/example/alexnet.cpp
 ##########
 @@ -306,19 +310,20 @@ int main(int argc, char const *argv[]) {
     LG << "ITER: " << iter << " Val LogLoss: " << logloss_val.Get();
 
     /*save the parameters*/
-    stringstream ss;
-    ss << iter;
-    string iter_str;
-    ss >> iter_str;
-    string save_path_param = "./model/alex_param_" + iter_str;
-    auto save_args = args_map;
-    /*we do not want to save the data and label*/
-    save_args.erase(save_args.find("data"));
-    save_args.erase(save_args.find("label"));
-    /*the alexnet does not get any aux array, so we do not need to save
-     * aux_map*/
-    LG << "ITER: " << iter << " Saving to..." << save_path_param;
-    NDArray::Save(save_path_param, save_args);
+    // Need to be fixed
 
 Review comment:
   yes, it was throwing error while saving when running on GPU. I was curious does NDArray::Save
copies the GPU data to CPU before trying to save to CPU memory.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message