From commits-return-32494-apmail-mxnet-commits-archive=mxnet.apache.org@mxnet.incubator.apache.org Fri Apr 20 01:47:53 2018 Return-Path: X-Original-To: apmail-mxnet-commits-archive@minotaur.apache.org Delivered-To: apmail-mxnet-commits-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id E19E818FF2 for ; Fri, 20 Apr 2018 01:47:52 +0000 (UTC) Received: (qmail 39655 invoked by uid 500); 20 Apr 2018 01:47:52 -0000 Delivered-To: apmail-mxnet-commits-archive@mxnet.apache.org Received: (qmail 39626 invoked by uid 500); 20 Apr 2018 01:47:52 -0000 Mailing-List: contact commits-help@mxnet.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@mxnet.incubator.apache.org Delivered-To: mailing list commits@mxnet.incubator.apache.org Received: (qmail 39617 invoked by uid 99); 20 Apr 2018 01:47:52 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 20 Apr 2018 01:47:52 +0000 From: GitBox To: commits@mxnet.apache.org Subject: [GitHub] TaoLv commented on a change in pull request #10616: ensure same mkldnn engine is used for consistency Message-ID: <152418887221.3652.5564177536005242495.gitbox@gitbox.apache.org> Date: Fri, 20 Apr 2018 01:47:52 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit TaoLv commented on a change in pull request #10616: ensure same mkldnn engine is used for consistency URL: https://github.com/apache/incubator-mxnet/pull/10616#discussion_r182928254 ########## File path: src/operator/nn/mkldnn/mkldnn_base-inl.h ########## @@ -67,7 +67,8 @@ class CpuEngine { public: static CpuEngine *Get() { // I's thread-safe in C++11. Review comment: So we need remove this line of comment? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services