From commits-return-31479-apmail-mxnet-commits-archive=mxnet.apache.org@mxnet.incubator.apache.org Thu Apr 12 00:00:10 2018 Return-Path: X-Original-To: apmail-mxnet-commits-archive@minotaur.apache.org Delivered-To: apmail-mxnet-commits-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 5510D18FB8 for ; Thu, 12 Apr 2018 00:00:10 +0000 (UTC) Received: (qmail 59749 invoked by uid 500); 12 Apr 2018 00:00:10 -0000 Delivered-To: apmail-mxnet-commits-archive@mxnet.apache.org Received: (qmail 59717 invoked by uid 500); 12 Apr 2018 00:00:10 -0000 Mailing-List: contact commits-help@mxnet.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@mxnet.incubator.apache.org Delivered-To: mailing list commits@mxnet.incubator.apache.org Received: (qmail 59708 invoked by uid 99); 12 Apr 2018 00:00:10 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 12 Apr 2018 00:00:10 +0000 From: GitBox To: commits@mxnet.apache.org Subject: [GitHub] aaronmarkham commented on a change in pull request #10485: [MXNET-304][RFC] Jenkins docs build Message-ID: <152349120962.2367.16220888831128093094.gitbox@gitbox.apache.org> Date: Thu, 12 Apr 2018 00:00:09 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit aaronmarkham commented on a change in pull request #10485: [MXNET-304][RFC] Jenkins docs build URL: https://github.com/apache/incubator-mxnet/pull/10485#discussion_r180932311 ########## File path: docs/build_version_doc/build_all_version.sh ########## @@ -59,16 +61,21 @@ for tag in $tag_list; do then git checkout master git pull + # Copy the latest README.md to the site root + cp README.md ../$built else git checkout "tags/$tag" fi # this gets around the Python 3 support issue in old versions of mxdoc.py - if [ $tag == '0.11.0' ] - then - git checkout master -- docs/mxdoc.py - fi - git submodule update || exit 1 - git submodule update --init --recursive + + # uncomment this if you must build in a Python 3 environment Review comment: Well, that section solves a really annoying problem with building in Python 3 for v0.12.0 or 0.11.0. However, the scala namespace change that just went in breaks that solution. I am figuring that 99% of time most operations will build the latest versions, or it can build the old versions in Python 2, but, if that 1% pops up, you know what to do. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services