mxnet-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] marcoabreu commented on a change in pull request #10731: Fix a bug in getting MKLDNN memory
Date Mon, 30 Apr 2018 19:37:42 GMT
marcoabreu commented on a change in pull request #10731: Fix a bug in getting MKLDNN memory
URL: https://github.com/apache/incubator-mxnet/pull/10731#discussion_r185087198
 
 

 ##########
 File path: ci/docker/runtime_functions.sh
 ##########
 @@ -313,16 +313,22 @@ build_ubuntu_amalgamation_min() {
 build_ubuntu_gpu_cmake_mkldnn() {
     set -ex
     cd /work/build
+    # We need to use generic archtecture. Otherwise, MKLDNN compiled in one
+    # CPU architecture (e.g., C5) can't run on another architecture (e.g., g3).
     cmake \
         -DUSE_CUDA=1               \
         -DUSE_CUDNN=1              \
         -DUSE_MKLML_MKL=1          \
         -DUSE_MKLDNN=1             \
         -DCMAKE_BUILD_TYPE=Release \
+        -DARCH_OPT_FLAGS="-mtune=generic" \
 
 Review comment:
   I see, so MKLDNN auto-assumes the runtime architecture based on the runtime-architecture.
I think this will cause quite some problems for our users in production environments, considering
everybody will build their binaries in a build fleet and deploy it in a production fleet with
different configuration and hardware.
   
   Could you please elaborate the flow how users are being made aware of this problem and
how we instruct them to solve this problem? Also, where is ARCH_OPT_FLAGS being consumed?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message