mxnet-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] ThomasDelteil commented on a change in pull request #10623: [MXNET-339] Add warning on input data for RNN for layout NTC
Date Sun, 22 Apr 2018 21:31:38 GMT
ThomasDelteil commented on a change in pull request #10623: [MXNET-339] Add warning on input
data for RNN for layout NTC
URL: https://github.com/apache/incubator-mxnet/pull/10623#discussion_r183252192
 
 

 ##########
 File path: python/mxnet/gluon/rnn/rnn_layer.py
 ##########
 @@ -286,6 +286,9 @@ class RNN(_RNNLayer):
     Inputs:
         - **data**: input tensor with shape `(sequence_length, batch_size, input_size)`
           when `layout` is "TNC". For other layouts dimensions are permuted accordingly.
+          Be aware that a `transpose` operation with a ndarray results in a new allocation
of
 
 Review comment:
   that's true, What I mean is:
   read data into numpy NTC -> nd array NTC -> nd array TNC  = 2 copies
   read data into numpy NTC -> numpy TNC -> nd array TNC = 1 copy
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message