mxnet-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] zheng-da opened a new pull request #10624: Fix a bug in the MKLDNN integration.
Date Fri, 20 Apr 2018 04:31:27 GMT
zheng-da opened a new pull request #10624: Fix a bug in the MKLDNN integration.
URL: https://github.com/apache/incubator-mxnet/pull/10624
 
 
   ## Description ##
   This is to fix a bug in https://github.com/apache/incubator-mxnet/issues/10580
   The bug happens when an NDArray already has a MKLDNN memory with a special MKLDNN format.
In some cases (group convolution), the MKLDNN memory uses 5 dimensions, while the NDArray
still uses 4 dimensions. In this case, when GetMKLDNNData is called, SetMKLMem will discard
the original MKLDNN memory due to incompatible dimensions between MKLDNN memory and NDArray.
This messes up the data in the NDArray.
   
   The test code in the PR can actually reproduce the bug in https://github.com/apache/incubator-mxnet/issues/10580
   
   Thank @TaoLv @pengzhao-intel for finding the root cause of this bug.
   
   ## Checklist ##
   ### Essentials ###
   Please feel free to remove inapplicable items for your PR.
   - [ ] The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant
[JIRA issue](https://issues.apache.org/jira/projects/MXNET/issues) created (except PRs with
tiny changes)
   - [ ] Changes are complete (i.e. I finished coding on this PR)
   - [ ] All changes have test coverage:
   - Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
   - Nightly tests are added for complicated/long-running ones (e.g. changing distributed
kvstore)
   - Build tests will be added for build configuration changes (e.g. adding a new build option
with NCCL)
   - [ ] Code is well-documented: 
   - For user-facing API changes, API doc string has been updated. 
   - For new C++ functions in header files, their functionalities and arguments are documented.

   - For new examples, README.md is added to explain the what the example does, the source
of the dataset, expected performance on test set and reference to the original paper if applicable
   - Check the API doc at http://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
   - [ ] To the my best knowledge, examples are either not affected by this change, or have
been fixed to be compatible with this change
   
   ### Changes ###
   - [ ] Feature1, tests, (and when applicable, API doc)
   - [ ] Feature2, tests, (and when applicable, API doc)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message