mxnet-commits mailing list archives

ashokei commented on a change in pull request #10021: [MXNET-33] SSD example not working with
mkl-dnn
URL: https://github.com/apache/incubator-mxnet/pull/10021#discussion_r172909508
 
 

 ##########
 File path: src/operator/nn/mkldnn/mkldnn_pooling-inl.h
 ##########
 @@ -92,6 +92,8 @@ inline bool SupportMKLDNNPooling(const PoolingParam &param,
 
   if (param.pooling_convention == pool_enum::kValid)
     return true;
+  else
+    return false;
 
 Review comment:
   @piiswrong the later code is being disabled for now until we support all "full" pooling
convention cases.  As @TaoLv mentioned, i will add a unit-test for this failure. 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services