mxnet-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] anirudh2290 opened a new pull request #10587: Remove pip upgrade step from install docs
Date Tue, 17 Apr 2018 23:01:10 GMT
anirudh2290 opened a new pull request #10587: Remove pip upgrade step from install docs
URL: https://github.com/apache/incubator-mxnet/pull/10587
 
 
   ## Description ##
   It is not advised to upgrade a system pip package(install with debian package manager for
example) to be upgraded by doing `pip install -U pip` (https://github.com/pypa/pip/issues/5221).
I don't think we need this upgrade step here since MXNet installs fine with the pip version
that is available after doing `sudo apt-get install python-pip`. Please see the PIP upgrade
issue: https://github.com/pypa/pip/issues/5221 . We ran into this issue when running the nightlies.
   Removed the upgrade step in this PR. 
   
   ## Checklist ##
   ### Essentials ###
   Please feel free to remove inapplicable items for your PR.
   - [ ] The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant
[JIRA issue](https://issues.apache.org/jira/projects/MXNET/issues) created (except PRs with
tiny changes)
   - [ ] Changes are complete (i.e. I finished coding on this PR)
   - [ ] All changes have test coverage:
   - Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
   - Nightly tests are added for complicated/long-running ones (e.g. changing distributed
kvstore)
   - Build tests will be added for build configuration changes (e.g. adding a new build option
with NCCL)
   - [ ] Code is well-documented: 
   - For user-facing API changes, API doc string has been updated. 
   - For new C++ functions in header files, their functionalities and arguments are documented.

   - For new examples, README.md is added to explain the what the example does, the source
of the dataset, expected performance on test set and reference to the original paper if applicable
   - Check the API doc at http://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
   - [ ] To the my best knowledge, examples are either not affected by this change, or have
been fixed to be compatible with this change
   
   ### Changes ###
   - [ ] Feature1, tests, (and when applicable, API doc)
   - [ ] Feature2, tests, (and when applicable, API doc)
   
   ## Comments ##
   - If this change is a backward incompatible change, why must this change be made.
   - Interesting edge cases to note here
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message