mxnet-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <>
Subject [GitHub] piiswrong closed pull request #10534: [MXNET-315] Fix the version select in the navbar to be independent of order
Date Tue, 17 Apr 2018 21:22:11 GMT
piiswrong closed pull request #10534: [MXNET-315] Fix the version select in the navbar to be
independent of order

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/docs/build_version_doc/ b/docs/build_version_doc/
index 27a39724ff8..b625a2e1b6a 100755
--- a/docs/build_version_doc/
+++ b/docs/build_version_doc/
@@ -27,6 +27,7 @@
                         help='Current version')
 parser.add_argument('--root_url', type=str, default='',
                         help='Root URL')
+parser.add_argument('--tag_default', type=str, default='master', help='Default Tag')
 if __name__ == '__main__':
     args = parser.parse_args()
@@ -46,7 +47,7 @@
                          'style="position: relative">' \
                          '<a href="#" tabindex="-1">Versions(%s)</a><ul class="dropdown-menu">'
% (args.current_version)
     for i, tag in enumerate(tag_list):
-        url = root_url if i == 0 else root_url + 'versions/%s/index.html' % (tag)
+        url = root_url if tag == args.tag_default else root_url + 'versions/%s/index.html'
% (tag)
         version_str += '<li><a class="main-nav-link" href=%s>%s</a></li>'
% (url, tag)
         version_str_mobile += '<li><a tabindex="-1" href=%s>%s</a></li>'
% (url, tag)
     version_str += '</ul></span>'
diff --git a/docs/build_version_doc/ b/docs/build_version_doc/
index 90d4fa68d7c..4d80ce48095 100755
--- a/docs/build_version_doc/
+++ b/docs/build_version_doc/
@@ -93,7 +93,7 @@ function update_mxnet_css {
 for tag in $tag_list; do
     # This Python script is expecting the tag_list.txt and it will use that as the entries
to populate
-    python --root_url "$root_url" --file_path "$built/versions/$tag" --current_version
"$tag" || exit 1
+    python --root_url "$root_url" --file_path "$built/versions/$tag" --current_version
"$tag" --tag_default "$tag_default" || exit 1
     # Patch any fixes to all versions except 0.11.0.
     # Version 0.11.0 has old theme and does not make use of the current mxnet.css


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:

With regards,
Apache Git Services

View raw message