mxnet-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <>
Subject [GitHub] haojin2 opened a new pull request #10533: [MXNET-314] [WIP] Support Integer Type parsing in CSVIter
Date Thu, 12 Apr 2018 21:30:40 GMT
haojin2 opened a new pull request #10533: [MXNET-314] [WIP] Support Integer Type parsing in
   ## Description ##
   Support parsing of int32 type in CSVIter
   ## Checklist ##
   ### Essentials ###
   Please feel free to remove inapplicable items for your PR.
   - [x] The PR title starts with [MXNET-314]
   - [x] Changes are complete (i.e. I finished coding on this PR)
   - [ ] All changes have test coverage:
   - Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
   - Nightly tests are added for complicated/long-running ones (e.g. changing distributed
   - Build tests will be added for build configuration changes (e.g. adding a new build option
with NCCL)
   - [x] Code is well-documented: 
   - For user-facing API changes, API doc string has been updated. 
   - For new C++ functions in header files, their functionalities and arguments are documented.

   - For new examples, is added to explain the what the example does, the source
of the dataset, expected performance on test set and reference to the original paper if applicable
   - Check the API doc at$PR_ID/$BUILD_ID/index.html
   - [x] To the my best knowledge, examples are either not affected by this change, or have
been fixed to be compatible with this change
   ### Changes ###
   - [x] Support integer data type in CSVIter
   - [ ] Corresponding tests for the new CSVIter
   ## Comments ##
   In the past all parsers default to parse the files in real_t type, but when the files contain
large integers we lose precision. e.g. 20000001 actually will have the same float32 representation
as 20000000. To provide a way to accurately read the data for users who have such needs, we
need to let the iterators be able to support parsing the input texts as integers.
   This PR depends on dmlc/dmlc-core#388 to build work properly.

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:

With regards,
Apache Git Services

View raw message