mxnet-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] lebeg commented on a change in pull request #10510: [MXNET-311] Change the docker image for Installation Guide Test - needs sudo
Date Thu, 12 Apr 2018 08:17:14 GMT
lebeg commented on a change in pull request #10510: [MXNET-311] Change the docker image for
Installation Guide Test - needs sudo
URL: https://github.com/apache/incubator-mxnet/pull/10510#discussion_r180998909
 
 

 ##########
 File path: tests/jenkins/run_test_installation_docs.sh
 ##########
 @@ -298,17 +298,20 @@ LINUX_PYTHON_GPU_END_LINENO=$(grep -n "END - Linux Python GPU Installation
Instr
 
 set_instruction_set ${LINUX_PYTHON_GPU_START_LINENO} ${LINUX_PYTHON_GPU_END_LINENO}
 
+
+# mxnet/base-cuda9 is a simple Docker Image with 'nvidia/cuda:9.0-cudnn7-devel' and 'apt-get
install sudo'.
+
 echo
 echo "### Testing Virtualenv ###"
 echo "${virtualenv_commands}"
 echo
-nvidia-docker run --rm nvidia/cuda:9.0-cudnn7-devel bash -c "${virtualenv_commands}"
+nvidia-docker run --rm mxnet/base-cuda9 bash -c "${virtualenv_commands}"
 
 Review comment:
   Where can I see the contents of this image? Also it would be good to keep consistency with
nvidia images (I assume they are taken as base anyway) and name and branch them with minor
versions of cuda: ```mxnet/base:cuda9.0``` ```mxnet/base:cuda9.1```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message