mxnet-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] aaronmarkham commented on a change in pull request #10485: [MXNET-304][RFC] Jenkins docs build
Date Thu, 12 Apr 2018 00:00:09 GMT
aaronmarkham commented on a change in pull request #10485: [MXNET-304][RFC] Jenkins docs build
URL: https://github.com/apache/incubator-mxnet/pull/10485#discussion_r180932311
 
 

 ##########
 File path: docs/build_version_doc/build_all_version.sh
 ##########
 @@ -59,16 +61,21 @@ for tag in $tag_list; do
         then
             git checkout master
             git pull
+            # Copy the latest README.md to the site root
+            cp README.md ../$built
         else
             git checkout "tags/$tag"
     fi
     # this gets around the Python 3 support issue in old versions of mxdoc.py
-    if [ $tag == '0.11.0' ]
-      then
-          git checkout master -- docs/mxdoc.py
-    fi
-    git submodule update || exit 1
-    git submodule update --init --recursive
+
+    # uncomment this if you must build in a Python 3 environment
 
 Review comment:
   Well, that section solves a really annoying problem with building in Python 3 for v0.12.0
or 0.11.0. However, the scala namespace change that just went in breaks that solution. I am
figuring that 99% of time most operations will build the latest versions, or it can build
the old versions in Python 2, but, if that 1% pops up, you know what to do.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message