mxnet-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] eric-haibin-lin commented on a change in pull request #10371: [MXNET-263] [WIP] Support for dot(dns, csr) = dns and dot(dns, csr.T) = dns on GPU
Date Tue, 03 Apr 2018 21:29:12 GMT
eric-haibin-lin commented on a change in pull request #10371: [MXNET-263] [WIP] Support for
dot(dns, csr) = dns and dot(dns, csr.T) = dns on GPU
URL: https://github.com/apache/incubator-mxnet/pull/10371#discussion_r178964889
 
 

 ##########
 File path: src/operator/tensor/dot.cu
 ##########
 @@ -23,10 +23,142 @@
  */
 
 #include "./dot-inl.h"
+#include <cub/cub.cuh>
 
 namespace mxnet {
 namespace op {
 
+template<typename gpu>
 
 Review comment:
   It looks like for dot, gpu kernels are in `dot-inl.cuh`. Let's move the implementation
here 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message