mxnet-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] piiswrong commented on issue #10345: allow block setattr to reset the prefix when setting new block
Date Mon, 02 Apr 2018 18:39:53 GMT
piiswrong commented on issue #10345: allow block setattr to reset the prefix when setting new
block
URL: https://github.com/apache/incubator-mxnet/pull/10345#issuecomment-378005952
 
 
   We should raise a warning when assign blocks with non-matching prefix.
   In python copy on assignment only happens for builtin types. This kind of hidden protocol
that decides when to copy is a hack.
   
   Also `net2.block1 = net1.block1` itself is a hack. The right approach is to define a new
block and compose them.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message